Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests #566

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix unit tests #566

wants to merge 2 commits into from

Conversation

usmanatron
Copy link

After cloning a fresh copy of master, I hit a number of unit test failures. The following changes fix all the issues I found running the tests. Everything is now green for me :-)

@TravisBuddy
Copy link

Hey @usmanatron,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 302f5e30-0392-11e9-87e5-3d0a59f34ca1

pedrofracassi
pedrofracassi approved these changes Feb 19, 2019
View reviewed changes
Copy link

@pedrofracassi pedrofracassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrofracassi pedrofracassi pedrofracassi approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usmanatron @TravisBuddy @pedrofracassi